Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Drosera #981

Closed
wants to merge 4 commits into from
Closed

feat: support Drosera #981

wants to merge 4 commits into from
+54 −0

Conversation

kingsley-einstein
Copy link

Resolves #979

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Dec 21, 2024 •
edited
Loading

@kingsley-einstein kingsley-einstein marked this pull request as ready for review January 1, 2025 19:21
@rndquu rndquu requested a review from zugdev January 2, 2025 20:57
rndquu
rndquu requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kingsley-einstein

  1. Pls fix the comments
  2. Did you deploy the contracts to the testnet?
  3. Did you check that the trap works as expected?
  4. The trap must pause the contracts.
  5. CI should pass.

.gitmodules
@@ -46,3 +46,6 @@
path = packages/contracts/lib/aave-v3-periphery
url = https://github.com/aave/aave-v3-periphery
branch= master
[submodule "packages/contracts/lib/v3-periphery"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this submodule? It's not used anywhere.

packages/contracts/src/traps/ProtocolTrap.sol
@@ -0,0 +1,35 @@
pragma solidity ^0.8.0;

contract ProtocolTrap {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contract must implement ITrap.

packages/contracts/src/traps/ProtocolTrap.sol
}

function collect() external view returns (bytes memory) {
uint256 randomNumber = randomize();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of returning a random number?

@rndquu rndquu marked this pull request as draft January 2, 2025 21:03
@rndquu rndquu changed the title chore: initialize [#1](https://github.com/ubiquity/ubiquity-dollar/is… feat: support Drosera Jan 4, 2025
@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Jan 15, 2025

@kingsley-einstein, this task has been idle for a while. Please provide an update.

@kingsley-einstein
Copy link
Author

@rndquu
The trap contract has been deployed. For it to work, I think an operator has to opt into it. I'm guessing I'll have to opt to become an operator as no operator has opted in since I deployed the contract.

@rndquu
Copy link
Member

rndquu commented Jan 16, 2025

@rndquu The trap contract has been deployed. For it to work, I think an operator has to opt into it. I'm guessing I'll have to opt to become an operator as no operator has opted in since I deployed the contract.

Drosera runs its own operators and drosera team made us sure there will be at least 1 operator in our trap. So becoming an operator is unnecessary, it's drosera's job.

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Jan 21, 2025

@kingsley-einstein, this task has been idle for a while. Please provide an update.

@ubiquity-os ubiquity-os bot closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndquu rndquu rndquu requested changes

@zugdev zugdev Awaiting requested review from zugdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drosera integration
2 participants
@kingsley-einstein @rndquu